Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dialogue to PromptCMD #207

Merged
merged 7 commits into from
Aug 21, 2023
Merged

Add Dialogue to PromptCMD #207

merged 7 commits into from
Aug 21, 2023

Conversation

CaenJones
Copy link
Contributor

When I attempted to use "prompt" in the past, it hid my username so I could only see it after I sent a message.

When I attempted to use "prompt" in the past, it hid my username so I could only see it after I sent a message.
@CaenJones CaenJones changed the title Update promptCMD so incorrect user syntax does not hid username Add errors to promptCMD Aug 18, 2023
@CaenJones
Copy link
Contributor Author

YEAH!

@quackduck
Copy link
Owner

Afaict, the change here is that empty prompts aren’t allowed and print an error message. I think empty prompts should be allowed but we can have devbot DM something like “(Your prompt is now empty. Did you mean to get more info about your prompt? Run man prompt for more info)”. Also we don’t really need a whole new setPrompt function: just change the original one to print a message! We dont need the errors package either :)

@CaenJones CaenJones changed the title Add errors to promptCMD Add Dialogue to PromptCMD Aug 18, 2023
commands.go Outdated Show resolved Hide resolved
commands.go Outdated Show resolved Hide resolved
commands.go Outdated Show resolved Hide resolved
@quackduck quackduck self-requested a review August 21, 2023 20:35
@quackduck quackduck merged commit 8d86039 into quackduck:main Aug 21, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants